-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Spray-json 1.3.5 security fix release #4106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR is consistently ailing in system test (see #3246) which seems unrelated to this change (builds on master also failed for same test a day ago). |
Codecov Report
@@ Coverage Diff @@
## master #4106 +/- ##
==========================================
- Coverage 84.55% 81.04% -3.52%
==========================================
Files 148 148
Lines 7122 7122
Branches 426 434 +8
==========================================
- Hits 6022 5772 -250
- Misses 1100 1350 +250
Continue to review full report at Codecov.
|
Finally its green after retrying build 3 times |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR Changes in test cases were required as spray json switched to using TreeMap
to avoid some of the hashing attacks. This change the ordering of field in string output hence switched to json object based comparison
Adapt test to use json object comparison instead of string comparison
Spray Json released a new version 1.3.5 which has few security fixes
My changes affect the following components
Types of changes
Checklist: