Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use focal release for travis ci #5052

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

jiangpengcheng
Copy link
Contributor

Seems travis ci is broken again, trying to fix it

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-io
Copy link

Codecov Report

Merging #5052 (e8950b5) into master (a6ad9e4) will decrease coverage by 11.39%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5052       +/-   ##
===========================================
- Coverage   82.65%   71.25%   -11.40%     
===========================================
  Files         206      199        -7     
  Lines       10000     9735      -265     
  Branches      438      435        -3     
===========================================
- Hits         8265     6937     -1328     
- Misses       1735     2798     +1063     
Impacted Files Coverage Δ
...che/openwhisk/core/invoker/LogStoreCollector.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.85%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...a/org/apache/openwhisk/http/BasicHttpService.scala 3.33% <0.00%> (-86.67%) ⬇️
...la/org/apache/openwhisk/http/BasicRasService.scala 16.66% <0.00%> (-83.34%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ad9e4...e8950b5. Read the comment docs.

Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@style95 style95 merged commit 5a847e3 into apache:master Jan 25, 2021
@@ -252,7 +252,8 @@ class WskAdminTests extends TestHelpers with WskActorSystem with Matchers with B
// check correctly set
val lines = wskadmin.cli(Seq("limits", "get", subject)).stdout.linesIterator.toSeq
lines should have size 1
lines(0) shouldBe "allowedKinds = [u'nodejs:10', u'blackbox']"
lines(0) should (be("allowedKinds = [u'nodejs:10', u'blackbox']") or be(
"allowedKinds = ['nodejs:10', 'blackbox']"))
Copy link
Contributor

@ningyougang ningyougang Jul 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my env, seems here has relation with python version, test as below:

  • If use python3 as default: ln -s /usr/bin/python3 /usr/bin/python

    lines(0) is ['nodejs:10', 'blackbox']

  • If use python2 as default: ln -s /usr/bin/python2 /usr/bin/python

    lines(0) is [u'nodejs:10', u'blackbox']

So here meets 2 cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants