-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use focal release for travis ci #5052
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5052 +/- ##
===========================================
- Coverage 82.65% 71.25% -11.40%
===========================================
Files 206 199 -7
Lines 10000 9735 -265
Branches 438 435 -3
===========================================
- Hits 8265 6937 -1328
- Misses 1735 2798 +1063
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -252,7 +252,8 @@ class WskAdminTests extends TestHelpers with WskActorSystem with Matchers with B | |||
// check correctly set | |||
val lines = wskadmin.cli(Seq("limits", "get", subject)).stdout.linesIterator.toSeq | |||
lines should have size 1 | |||
lines(0) shouldBe "allowedKinds = [u'nodejs:10', u'blackbox']" | |||
lines(0) should (be("allowedKinds = [u'nodejs:10', u'blackbox']") or be( | |||
"allowedKinds = ['nodejs:10', 'blackbox']")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my env, seems here has relation with python version, test as below:
-
If use python3 as default:
ln -s /usr/bin/python3 /usr/bin/python
lines(0)
is['nodejs:10', 'blackbox']
-
If use python2 as default:
ln -s /usr/bin/python2 /usr/bin/python
lines(0)
is[u'nodejs:10', u'blackbox']
So here meets 2 cases.
Seems travis ci is broken again, trying to fix it
Description
Related issue and scope
My changes affect the following components
Types of changes
Checklist: