-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix for topics #5062
Add prefix for topics #5062
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5062 +/- ##
==========================================
- Coverage 82.80% 75.88% -6.93%
==========================================
Files 207 207
Lines 10034 10047 +13
Branches 444 418 -26
==========================================
- Hits 8309 7624 -685
- Misses 1725 2423 +698
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
- Add prefix for topics - Add extra prefix for userEvent topic only
eb2e900
to
1b73098
Compare
Codecov Report
@@ Coverage Diff @@
## master #5062 +/- ##
===========================================
+ Coverage 38.79% 74.63% +35.84%
===========================================
Files 218 220 +2
Lines 10700 10822 +122
Branches 454 445 -9
===========================================
+ Hits 4151 8077 +3926
+ Misses 6549 2745 -3804
Continue to review full report at Codecov.
|
Description
This pr's target is, add prefix for all topics and add extra prefix for userEvent topic only.
After applied this pr, some zones(e.g. test1, test2, test3) can share same kafka instance using different prefix topic,
BTW, userEvent is special, user may want to send some zones's event to same topic, so added extra prefix for it, user can decide whether want to send the event to same topic or different topic.
I tested in my local env
Default configuration (all topics's prefix is empty string), topics name as below
kafka_topics_prefix: "blue_" and kafka_topics_userEvent_prefix: "test_"
And the activations are successful on above 2 cases both.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: