-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Scheduler] Add a centralized watcher for etcd data #5069
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5069 +/- ##
===========================================
- Coverage 81.72% 28.36% -53.37%
===========================================
Files 210 204 -6
Lines 10167 9950 -217
Branches 440 447 +7
===========================================
- Hits 8309 2822 -5487
- Misses 1858 7128 +5270
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is given from #5063
isPrefix: Boolean, | ||
name: String, | ||
listenEvents: Set[EtcdEvent] = Set.empty) | ||
case class UnWatchEndpoint(watchKey: String, isPrefix: Boolean, watchName: String, needFeedback: Boolean = false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case class UnWatchEndpoint(watchKey: String, isPrefix: Boolean, watchName: String, needFeedback: Boolean = false) | |
case class UnwatchEndpoint(watchKey: String, isPrefix: Boolean, watchName: String, needFeedback: Boolean = false) |
LGTM |
Referring to review #5068 (review), you need to add |
LGTM |
Description
The FPC scheduler will use etcd to store and share some data, and some components need to get noticed for some data when they are changed(inserted, updated or removed), this PR implements a centralized watcher for them, which will watch all changes on etcd and distribute them to subscribers
design document: https://cwiki.apache.org/confluence/display/OPENWHISK/WatcherService
Related issue and scope
My changes affect the following components
Types of changes
Checklist: