Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php:8.0 kind #5071

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Add php:8.0 kind #5071

merged 1 commit into from
Feb 26, 2021

Conversation

akrabat
Copy link
Member

@akrabat akrabat commented Feb 25, 2021

Also, set example PHP runtime to v7.4.

Also, set example PHP runtime to v7.4.
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akrabat
Copy link
Member Author

akrabat commented Feb 25, 2021

Is the build failure due to this change or something else? It looks like there's a Python 2.7 issue.

@dgrove-oss
Copy link
Member

Looks to me like there's an intermediate state in an upstream ubuntu security update. Wait a bit and try again. It's hitting other pipelines too.

@codecov-io
Copy link

codecov-io commented Feb 25, 2021

Codecov Report

Merging #5071 (bd8a08d) into master (ed58b23) will decrease coverage by 7.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5071      +/-   ##
==========================================
- Coverage   81.61%   74.34%   -7.28%     
==========================================
  Files         204      204              
  Lines        9950     9950              
  Branches      447      447              
==========================================
- Hits         8121     7397     -724     
- Misses       1829     2553     +724     
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.85%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0.00% <0.00%> (-78.58%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0.00% <0.00%> (-74.08%) ⬇️
...ore/database/azblob/AzureBlobAttachmentStore.scala 11.53% <0.00%> (-60.58%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed58b23...bd8a08d. Read the comment docs.

@rabbah rabbah merged commit d8cf172 into apache:master Feb 26, 2021
@akrabat akrabat deleted the php-8.0 branch February 27, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants