-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated error #5128
Fix deprecated error #5128
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5128 +/- ##
===========================================
+ Coverage 28.91% 74.60% +45.68%
===========================================
Files 219 233 +14
Lines 11775 12661 +886
Branches 506 521 +15
===========================================
+ Hits 3405 9446 +6041
+ Misses 8370 3215 -5155
Continue to review full report at Codecov.
|
docReader: DocumentReader, | ||
actorSystem: ActorSystem, | ||
logging: Logging, | ||
materializer: ActorMaterializer): ArtifactStore[D] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we don't need a materializer at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems yes
} | ||
|
||
probe.expectMsg(Transition(machine, Paused, Running)) | ||
pool.expectMsgType[Resumed] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea for using separate probe object
Description
Fix deprecated error
Related issue and scope
My changes affect the following components
Types of changes
Checklist: