Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated error #5128

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Conversation

jiangpengcheng
Copy link
Contributor

Description

Fix deprecated error

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #5128 (6b1481f) into master (ecb2a98) will increase coverage by 45.68%.
The diff coverage is 52.78%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5128       +/-   ##
===========================================
+ Coverage   28.91%   74.60%   +45.68%     
===========================================
  Files         219      233       +14     
  Lines       11775    12661      +886     
  Branches      506      521       +15     
===========================================
+ Hits         3405     9446     +6041     
+ Misses       8370     3215     -5155     
Impacted Files Coverage Δ
.../containerpool/logging/ElasticSearchLogStore.scala 92.85% <ø> (+92.85%) ⬆️
...sk/core/containerpool/logging/SplunkLogStore.scala 81.81% <0.00%> (+81.81%) ⬆️
...ache/openwhisk/core/database/ActivationStore.scala 92.30% <ø> (ø)
...penwhisk/core/database/ArtifactStoreProvider.scala 66.66% <ø> (ø)
...he/openwhisk/core/database/AttachmentSupport.scala 100.00% <ø> (+26.31%) ⬆️
...che/openwhisk/core/database/CouchDbRestStore.scala 71.21% <ø> (+19.69%) ⬆️
...ore/database/azblob/AzureBlobAttachmentStore.scala 11.53% <ø> (+11.53%) ⬆️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <ø> (ø)
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala 7.69% <ø> (+7.69%) ⬆️
...e/elasticsearch/ElasticSearchActivationStore.scala 84.66% <ø> (+23.92%) ⬆️
... and 222 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9279626...6b1481f. Read the comment docs.

docReader: DocumentReader,
actorSystem: ActorSystem,
logging: Logging,
materializer: ActorMaterializer): ArtifactStore[D] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we don't need a materializer at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems yes

}

probe.expectMsg(Transition(machine, Paused, Running))
pool.expectMsgType[Resumed]
Copy link
Contributor

@ningyougang ningyougang Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea for using separate probe object

@dgrove-oss dgrove-oss merged commit 20417de into apache:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants