Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor version bump of azure-storage-blob to fix builds #5150

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

dgrove-oss
Copy link
Member

@dgrove-oss dgrove-oss commented Aug 16, 2021

It appears the version 12.6.0 of com.azure:azure-storage-blob has
been removed from the maven central repo. Our builds have been failing
for about 3 days trying to download it. Version 12.7.0 is available,
so hack around the build problems by upgrading one minor version.

A typical failing build is: https://app.travis-ci.com/github/apache/openwhisk-runtime-rust/jobs/531822834#L279

It appears the version 12.6.0 of com.azure:azure-storage-blob has
been removed from the maven central repo.  Our builds have been failing
for about 3 days trying to download it.  Version 12.7.0 is available,
so hack around the build problems by upgrading on minor version.

A typical failing build is: https://app.travis-ci.com/github/apache/openwhisk-runtime-rust/jobs/531822834#L279
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.74%. Comparing base (209dc44) to head (39605e3).
Report is 176 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5150       +/-   ##
===========================================
+ Coverage   43.63%   74.74%   +31.11%     
===========================================
  Files         231      231               
  Lines       12803    12803               
  Branches      501      501               
===========================================
+ Hits         5586     9570     +3984     
+ Misses       7217     3233     -3984     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@falkzoll falkzoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 .

@mhenke1 mhenke1 self-requested a review August 17, 2021 09:50
Copy link
Contributor

@mhenke1 mhenke1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhenke1 mhenke1 merged commit 3e6138d into apache:master Aug 17, 2021
@dgrove-oss dgrove-oss deleted the azure-storage-blob-hack branch August 17, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants