Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Scheduler] Update main method of the scheduler. #5157

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

style95
Copy link
Member

@style95 style95 commented Sep 15, 2021

Description

This is to update the main method of the scheduler.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@style95 style95 requested review from ningyougang, jiangpengcheng and bdoyle0182 and removed request for ningyougang September 15, 2021 14:44
@style95 style95 changed the title Update main method of the scheduler. [New Scheduler] Update main method of the scheduler. Sep 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #5157 (9ee0b27) into master (cf36299) will increase coverage by 29.18%.
The diff coverage is 1.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5157       +/-   ##
===========================================
+ Coverage   45.68%   74.86%   +29.18%     
===========================================
  Files         234      234               
  Lines       13382    13429       +47     
  Branches      541      551       +10     
===========================================
+ Hits         6113    10054     +3941     
+ Misses       7269     3375     -3894     
Impacted Files Coverage Δ
...rg/apache/openwhisk/common/AverageRingBuffer.scala 27.27% <ø> (ø)
...rg/apache/openwhisk/core/scheduler/Scheduler.scala 5.92% <0.00%> (-2.66%) ⬇️
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala 83.73% <ø> (ø)
.../core/scheduler/container/CreationJobManager.scala 83.33% <100.00%> (ø)
...pache/openwhisk/core/invoker/InvokerReactive.scala 59.48% <0.00%> (-18.97%) ⬇️
...whisk/connector/kafka/KafkaProducerConnector.scala 80.00% <0.00%> (-7.50%) ⬇️
...whisk/connector/kafka/KafkaConsumerConnector.scala 81.69% <0.00%> (-5.64%) ⬇️
...pache/openwhisk/core/containerpool/Container.scala 89.65% <0.00%> (-1.15%) ⬇️
...e/openwhisk/core/containerpool/ContainerPool.scala 96.86% <0.00%> (+1.56%) ⬆️
.../org/apache/openwhisk/core/entity/EntityPath.scala 100.00% <0.00%> (+1.88%) ⬆️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf36299...9ee0b27. Read the comment docs.

@bdoyle0182
Copy link
Contributor

LGTM

@style95 style95 merged commit d9394f4 into apache:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants