Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ansible with new scheduler instructions #5202

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

hunhoffe
Copy link
Contributor

Add instructions to add configuration for akka dispatcher, add complete file paths in two places

Description

When trying to deploy the new scheduler with ansible, I kept getting this error in the scheduler:

Exception in thread "main" akka.ConfigurationException: Dispatcher [dispatchers.lease-service-dispatcher] not configured for path akka://scheduler-actor-system/user/$b

Adding the dispatcher to the references.conf file fixed the error, and now I can deploy the scheduler via ansible.
I've just tested this locally by invoking a few functions after deployment.

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • [N/A] I added tests to cover my changes.
  • [N/A] My changes require further changes to the documentation.
  • I updated the documentation where necessary.

Add instructions to add configuration for akka dispatcher, add complete file paths in two places
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #5202 (5f61366) into master (5332e6d) will increase coverage by 19.60%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5202       +/-   ##
===========================================
+ Coverage   44.65%   64.26%   +19.60%     
===========================================
  Files         238      238               
  Lines       13937    13937               
  Branches      581      581               
===========================================
+ Hits         6224     8957     +2733     
+ Misses       7713     4980     -2733     
Impacted Files Coverage Δ
...hisk/core/scheduler/message/ContainerMessage.scala 0.00% <0.00%> (-100.00%) ⬇️
.../openwhisk/core/scheduler/FPCSchedulerServer.scala 0.00% <0.00%> (-95.84%) ⬇️
...nwhisk/core/scheduler/queue/ContainerCounter.scala 0.00% <0.00%> (-92.11%) ⬇️
...sk/core/scheduler/container/ContainerManager.scala 0.00% <0.00%> (-88.72%) ⬇️
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala 0.00% <0.00%> (-83.74%) ⬇️
.../core/scheduler/container/CreationJobManager.scala 0.00% <0.00%> (-83.34%) ⬇️
...scheduler/queue/ElasticSearchDurationChecker.scala 0.00% <0.00%> (-80.77%) ⬇️
.../main/scala/org/apache/openwhisk/core/WarmUp.scala 21.42% <0.00%> (-78.58%) ⬇️
...core/scheduler/queue/SchedulingDecisionMaker.scala 0.00% <0.00%> (-73.18%) ⬇️
.../openwhisk/core/scheduler/queue/QueueManager.scala 8.00% <0.00%> (-65.46%) ⬇️
... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5332e6d...5f61366. Read the comment docs.

Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks, Erika for the contribution.

@bdoyle0182
Copy link
Contributor

bdoyle0182 commented Mar 23, 2022

LGTM, were about to start work with migrating to the new scheduler in April as well

@rabbah rabbah merged commit 829e734 into apache:master Mar 30, 2022
@hunhoffe hunhoffe deleted the scheduler-ansible branch July 11, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants