Fix new scheduler error #5206
Fix new scheduler error #5206
Conversation
| @@ -317,6 +317,8 @@ | |||
| "CONFIG_whisk_etcd_pool_threads": "{{ etcd.pool_threads }}" | |||
| "CONFIG_whisk_scheduler_grpc_tls": "{{ scheduler.grpc.tls | default('false') | lower }}" | |||
| "CONFIG_whisk_scheduler_maxPeek": "{{ scheduler.maxPeek }}" | |||
| "CONFIG_whisk_spi_LoadBalancerProvider": "org.apache.openwhisk.core.loadBalancer.FPCPoolBalancer" | |||
There was a problem hiding this comment.
Currently, this is guided to configure them alternatively.
https://github.com/apache/openwhisk/tree/master/ansible#optional-enable-the-new-scheduler
If we take this approach, how about changing the documentation too?
There was a problem hiding this comment.
this pr is only useful for ansible way(we may need other prs for k8s and standalone), so I think it's better to keep the document
Codecov Report
@@ Coverage Diff @@
## master #5206 +/- ##
===========================================
+ Coverage 44.65% 64.41% +19.76%
===========================================
Files 238 238
Lines 13937 13937
Branches 581 581
===========================================
+ Hits 6224 8978 +2754
+ Misses 7713 4959 -2754
Continue to review full report at Codecov.
|
| @@ -28,6 +28,7 @@ whisk.spi { | |||
| AuthenticationDirectiveProvider = org.apache.openwhisk.core.controller.BasicAuthenticationDirective | |||
| InvokerProvider = org.apache.openwhisk.core.invoker.InvokerReactive | |||
| InvokerServerProvider = org.apache.openwhisk.core.invoker.DefaultInvokerServer | |||
| DurationCheckerProvider = org.apache.openwhisk.core.scheduler.queue.NoopDurationCheckerProvider | |||
There was a problem hiding this comment.
Regardless of whether the ansible changes make it in, I think we should merge in the changes to this file so that service can at least run with all of the necessary providers. If you want to put this file's changes in a separate PR I'd approve that. Don't have an opinion on the ansible change
Add some missing configuration for new scheduler
Description
Related issue and scope
My changes affect the following components
Types of changes
Checklist: