[Scheduler Enhancement] Increase the retention timeout for the blackbox action. #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5266 +/- ##
===========================================
- Coverage 80.09% 65.71% -14.38%
===========================================
Files 238 238
Lines 14080 14122 +42
Branches 576 589 +13
===========================================
- Hits 11277 9280 -1997
- Misses 2803 4842 +2039
Continue to review full report at Codecov.
|
ningyougang
reviewed
Jul 5, 2022
| stay using data.copy(activeDuringFlush = false) | ||
| else | ||
| cleanUpActorsAndGotoRemoved(data) | ||
|
|
||
| case Event(GracefulShutdown, data: FlushingData) => | ||
| completeAllActivations(data.reason, ContainerCreationError.whiskErrors.contains(data.error)) | ||
| completeAllActivations(data.reason, isWhiskError(data.error)) |
There was a problem hiding this comment.
Our downstream didn't have this statement
completeAllActivations(data.reason, isWhiskError(data.error))
So, just add completeAllActivations, is it for safe?
There was a problem hiding this comment.
Nice catch. I added the case back.
ningyougang
approved these changes
Jul 5, 2022
|
LGTM |
JesseStutler
pushed a commit
to JesseStutler/openwhisk
that referenced
this pull request
Jul 13, 2022
…ox action. (apache#5266) * Increase the retention timeout for the blackbox action. * Fix test cases. * Apply scalaFmt. * Add GracefulShutdown case back. * Increase the blackbox timeout for test cases. * Access the private method directly. * Replace Thread.sleep with awaitAssert * Add the missing configuration. * Enhance the test code. * Remove thread.sleep. * Fix test cases. * Fix test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the blackbox actions, it may take more than 20 seconds which is a default in-progress timeout, to pull an image and it makes the activation timed out.
A memory queue no longer drop black-box activations in such a case with this change.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: