Go to the NamespaceThrottled state rather than Flushing state. #5303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NamespaceThrottling(dropMsg=true) message, but the Flushing state doesn't have a case to disable namespace throttling at all.
bdoyle0182
approved these changes
Aug 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #5303 +/- ##
==========================================
+ Coverage 71.46% 76.15% +4.68%
==========================================
Files 238 238
Lines 14183 14178 -5
Branches 574 579 +5
==========================================
+ Hits 10136 10797 +661
+ Misses 4047 3381 -666
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jiangpengcheng
approved these changes
Aug 3, 2022
msciabarra
pushed a commit
to nuvolaris/openwhisk
that referenced
this pull request
Nov 23, 2022
…e#5303) * Currently MemoryQueue will go to Flushing state when receive a EnableNamespaceThrottling(dropMsg=true) message, but the Flushing state doesn't have a case to disable namespace throttling at all. * Remove unused import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, MemoryQueue will go to the Flushing state when receiving an EnableNamespaceThrottling(dropMsg=true) message, but the Flushing state doesn't have a case to disable namespace throttling at all.
So without this change, the queue may not disable the namespace throttling.
Description
Related issue and scope
My changes affect the following components
Types of changes
Checklist: