-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub action #5361
GitHub action #5361
Conversation
Please note it is still incomplete because I have no idea of how to upload logs and how to see the results. |
Codecov Report
@@ Coverage Diff @@
## master #5361 +/- ##
===========================================
- Coverage 81.46% 57.36% -24.10%
===========================================
Files 240 240
Lines 14407 14407
Branches 618 601 -17
===========================================
- Hits 11736 8264 -3472
- Misses 2671 6143 +3472
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Logs are uploaded to IBM Bluemix. We need to see if this is still valid. @dgrove-oss, could you confirm if we can still use Bluemix to upload logs? |
Yes I see in the scripts there is a "box-upload.py" script uploading them to a wired-in path.
I am going to add also s3 upload so if you provide your keys it will upload to s3 instead.
…--
Michele Sciabarra
***@***.***
----- Original message -----
From: Dominic Kim ***@***.***>
To: apache/openwhisk ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [apache/openwhisk] GitHub action [WIP] (PR #5361)
Date: Saturday, December 10, 2022 1:10 AM
Logs are uploaded to IBM Bluemix.
https://github.com/apache/openwhisk/blob/master/tools/travis/box-upload.py#L46
We need to see if this is still valid.
I also have no access to the logs.
@dgrove-oss <https://github.com/dgrove-oss>, could you confirm if we can still use Bluemix to upload logs?
—
Reply to this email directly, view it on GitHub <#5361 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHJ4D36OOAHDQB3MFXMVPALWMPKCHANCNFSM6AAAAAASYRAF5Q>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
I updated the pull requests. It is now able to write on slack and upload logs to an S3 buckets. To use the PR we need to merge it and also add to GitHub all the secrets listed in the .github/workflows/README. |
How can we test this change? |
The workflow does not run and it is not visibile until it is available on the default branch so it shoud be merged. However currently the do not run unless you trigger them manually or push a tag. So we can test them merging and triggering manually. Or you can merge them in a fork as I am doing here (https://github.com/msciabarra/openwhisk/) |
…aming S3_LOG_BUCKET to AWS_BUCKET to fix tests
I fixed the error in the aws storage renaming a secret to AWS_BUCKET, and the error in system forcing a corresponding java version. I had to "slightly" update the version of openj9 used to use one that can be actually downloaded (11.0.8 -> 11.0.12) |
Now I have unit, multiruntime and standalone test passing and system only failing one test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this change is aligned with 1.0.0.
Is this will be updated to be aligned with the current master?
more cleanup added, removed all the changed files to fix 1.0.0, now triggered by push and pull-requests without tags |
To Dom's comment on aligning with master past 1.0.0 and the email sent to the dev list, I don't think master is broken. The CI tests should all pass, I think there was some flakiness with travis / the scheduler tests that would require you to re-kick the travis job to get them to pass; but master should be in a fine state. Thank you so much for the effort on this before the holidays. |
Sorry my mistake. Please merge now. I tested the build against my fork and it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @msciabarra
This is great work!
Generally LGTM with minor questions.
SLACK_WEBHOOK: ${{secrets.SLACK_WEBHOOK}} | ||
|
||
# (optional) s3 log upload | ||
AWS_BUCKET: ${{ secrets.AWS_BUCKET }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for NGROK, so now contributors are in charge of uploading logs to their own environment to figure out the failed tests of a PR.
For periodic tests against the upstream master branch, those who have permission can configure proper secrets for the upstream repo.
It needs to be discussed where to place such logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you can put your own AWS_BUCKET where you want. The bucket can be made public as I did here: https://nuvolaris-logs.s3.eu-central-1.amazonaws.com/index.html.
Instructions are in the README.
Actually, since there is already a bucket configured for some tests, it will be used!
Maybe this is not what the owner of the bucket wants.
We need to get a bucket from Amazon or from some other cloud provider, I am sure there are donations somewhere of resources that we can use...
|
||
If you want to get notified of what happens on slack, create an [Incoming Web Hook](https://api.slack.com/messaging/webhooks) and then set the following secret: | ||
|
||
- `SLACK_WEBHOOK`: the incoming webhook url provided by slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is also same. It would be great to discuss how/whether to configure this for the upstream repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use it with the current OpenWhisk slack. I do not know who has access to the slack configuration. All you need to do is to create an app and retrieve the incoming webhook. And you can use the exiting dev channel on OpenWhisk slack
@@ -0,0 +1,26 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this?
Seems it's being used here.
https://github.com/apache/openwhisk/pull/5361/files#diff-fc5257f5200a46b6baab3ca657b694cc84dc77e3a5f9d71062b25fce994c02b4R70
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to test the build without having to run a full test... it is handy to debug secrets and so on
# limitations under the License. | ||
# | ||
|
||
#if [[ $TEST_SUITE =~ Dummy ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might need to be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, if you do not want to defeat the goal of the dummy test to avoid to run a fast build withou waiting an hour...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this idea to skip tests for debugging.
How about making this as an input as well just like debugging enablement option so that users can easily trigger this feature without changing any code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is already there...if you launvh the dummy build and enable ngrok in a few second you get an ssh command to get into the vm with everythingalready setup to build and test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we control whether to run these dummy tests like this?
Also, there is the same code block, so can we delete these comments?
https://github.com/apache/openwhisk/pull/5361/files#diff-fc5257f5200a46b6baab3ca657b694cc84dc77e3a5f9d71062b25fce994c02b4R70
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you control the test from there. Select "Dummy" to run the dummy test. It is useful when also you enable Ngrok debugging so you get an ssh command to get into the CI build VM to experiment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok, I got confused.
My last question is what is the purpose of this commented block?
There is already uncommented one.
if [[ $TEST_SUITE =~ Dummy ]]
then echo skiping setup ; exit 0
fi```
@@ -15,6 +15,7 @@ | |||
* limitations under the License. | |||
*/ | |||
|
|||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this test commented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was an attempt to pass the travis build to merge... but looks like it does not work
# limitations under the License. | ||
# | ||
|
||
#if [[ $TEST_SUITE =~ Dummy ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we control whether to run these dummy tests like this?
Also, there is the same code block, so can we delete these comments?
https://github.com/apache/openwhisk/pull/5361/files#diff-fc5257f5200a46b6baab3ca657b694cc84dc77e3a5f9d71062b25fce994c02b4R70
Implements a port of the travis build for github actions
Description
This adds a Github action workflow and a port of the travis scripts to work with GitHubactions
Travis needs to be replaced
Related issue and scope
My changes affect the following components
Types of changes
Checklist: