Finish setup on error #5419
Merged
Finish setup on error #5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style95
commented
May 30, 2023
| @@ -221,8 +221,7 @@ class Scheduler(schedulerId: SchedulerInstanceId, schedulerEndpoints: SchedulerE | |||
| } | |||
|
|
|||
| val topic = s"${Scheduler.topicPrefix}scheduler${schedulerId.asString}" | |||
| val schedulerConsumer = | |||
| msgProvider.getConsumer(config, topic, topic, maxPeek, maxPollInterval = TimeLimit.MAX_DURATION + 1.minute) | |||
| val schedulerConsumer = msgProvider.getConsumer(config, topic, topic, maxPeek, maxPollInterval = TimeLimit.MAX_DURATION + 1.minute) | |||
There was a problem hiding this comment.
It is wrongly formatted for testing.
style95
force-pushed
the
finish-setup-on-error
branch
from
5301b75
to
abc705a
Compare
bdoyle0182
approved these changes
May 30, 2023
bdoyle0182
approved these changes
May 30, 2023
|
|
style95
commented
May 30, 2023
| @@ -20,6 +20,8 @@ | |||
| #then echo skipping setup ; exit 0 | |||
| #fi | |||
|
|
|||
| set -e | |||
There was a problem hiding this comment.
It is required to finish on an error.
Now it works as expected.
I will revert the temporary commit.
style95
force-pushed
the
finish-setup-on-error
branch
from
72fbb42
to
740e265
Compare
Codecov Report
@@ Coverage Diff @@
## master #5419 +/- ##
==========================================
- Coverage 76.63% 76.47% -0.17%
==========================================
Files 241 241
Lines 14630 14630
Branches 616 616
==========================================
- Hits 11212 11188 -24
- Misses 3418 3442 +24 see 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
22 tasks
mtt-merz
pushed a commit
to mtt-merz/openwhisk
that referenced
this pull request
Oct 22, 2023
* Fast-fail on errors * Fix an indentation error * Fail the setup script on an error (cherry picked from commit 88156c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to fast fail on any error.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: