Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1635: Download orc-format from dlcdn.apache.org instead of archive.apache.org #1820

Closed
wants to merge 1 commit into from

Conversation

progval
Copy link
Contributor

@progval progval commented Feb 26, 2024

What changes were proposed in this pull request?

Download orc-format from dlcdn.apache.org instead of archive.apache.org

Why are the changes needed?

https://archive.apache.org/ discourages heavy use, and its rate limits can cause CI systems building Apache ORC to be banned.

How was this patch tested?

It builds from a clean repo

Was this patch authored or co-authored using generative AI tooling?

no

https://archive.apache.org/ discourages heavy use, and its rate limits
can cause CI systems building Apache ORC to be banned.
@github-actions github-actions bot added the BUILD label Feb 26, 2024
@deshanxiao
Copy link
Contributor

deshanxiao commented Feb 26, 2024

Thanks @progval Pending CI.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @progval and @deshanxiao .

Are you sure with this?

IIRC, since Apache Download is only serving the latest versions, we cannot use it in the source code. The released branches are going to be broken easily when we release a new orc-format.

@dongjoon-hyun
Copy link
Member

Here are the example. You can see that 404 Error for Apache Spark 3.5.0.

$ curl --head https://dlcdn.apache.org/spark/spark-3.5.1/spark-3.5.1.tgz
HTTP/2 200
server: Apache
last-modified: Thu, 15 Feb 2024 11:39:51 GMT
etag: "21ae2b9-6116a15e24d57"
access-control-allow-origin: *
content-type: application/x-gzip
via: 1.1 varnish, 1.1 varnish
accept-ranges: bytes
age: 21
date: Mon, 26 Feb 2024 17:48:04 GMT
x-served-by: cache-hel1410020-HEL, cache-sjc10040-SJC
x-cache: MISS, HIT
x-cache-hits: 0, 0
x-timer: S1708969685.562024,VS0,VE45
content-length: 35316409
$ curl --head https://dlcdn.apache.org/spark/spark-3.5.0/spark-3.5.0.tgz
HTTP/2 404
server: Apache
content-type: text/html; charset=iso-8859-1
via: 1.1 varnish, 1.1 varnish
accept-ranges: bytes
date: Mon, 26 Feb 2024 17:48:11 GMT
age: 0
x-served-by: cache-hel1410022-HEL, cache-sjc1000130-SJC
x-cache: MISS, MISS
x-cache-hits: 0, 0
x-timer: S1708969691.332510,VS0,VE511
content-length: 196

@dongjoon-hyun
Copy link
Member

Let me close this to prevent any accidental merging first.

Feel free to reopen this if you have any other ways, @progval .

@douardda
Copy link
Contributor

Maybe we could put both URLs since the ExternalProject URL entry allows several entries.

@dongjoon-hyun
Copy link
Member

Maybe we could put both URLs since the ExternalProject URL entry allows several entries.

+1 for the suggestion, @douardda . You want to put dlcdn first as a cache, right?

@douardda
Copy link
Contributor

Maybe we could put both URLs since the ExternalProject URL entry allows several entries.

+1 for the suggestion, @douardda . You want to put dlcdn first as a cache, right?

yes

@progval
Copy link
Contributor Author

progval commented Feb 28, 2024

Submitted at #1830

@douardda
Copy link
Contributor

Submitted at #1830

thanks!

dongjoon-hyun pushed a commit that referenced this pull request Mar 1, 2024
…chive.apache.org

### What changes were proposed in this pull request?
Try downloading orc-format from dlcdn.apache.org before archive.apache.org

This replaces #1820 which required dlcdn to have the current version.

### Why are the changes needed?
https://archive.apache.org/ discourages heavy use, and its rate limits can cause CI systems building Apache ORC to be banned.

### How was this patch tested?
It builds from a clean repo

### Was this patch authored or co-authored using generative AI tooling?
no

Closes #1830 from progval/dlcdn2.

Authored-by: Valentin Lorentz <vlorentz@softwareheritage.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants