-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-1635: Download orc-format from dlcdn.apache.org instead of archive.apache.org #1820
Conversation
https://archive.apache.org/ discourages heavy use, and its rate limits can cause CI systems building Apache ORC to be banned.
Thanks @progval Pending CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @progval and @deshanxiao .
Are you sure with this?
IIRC, since Apache Download is only serving the latest versions, we cannot use it in the source code. The released branches are going to be broken easily when we release a new orc-format.
Here are the example. You can see that 404 Error for Apache Spark 3.5.0.
|
Let me close this to prevent any accidental merging first. Feel free to reopen this if you have any other ways, @progval . |
Maybe we could put both URLs since the ExternalProject URL entry allows several entries. |
+1 for the suggestion, @douardda . You want to put |
yes |
Submitted at #1830 |
thanks! |
…chive.apache.org ### What changes were proposed in this pull request? Try downloading orc-format from dlcdn.apache.org before archive.apache.org This replaces #1820 which required dlcdn to have the current version. ### Why are the changes needed? https://archive.apache.org/ discourages heavy use, and its rate limits can cause CI systems building Apache ORC to be banned. ### How was this patch tested? It builds from a clean repo ### Was this patch authored or co-authored using generative AI tooling? no Closes #1830 from progval/dlcdn2. Authored-by: Valentin Lorentz <vlorentz@softwareheritage.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
Download orc-format from dlcdn.apache.org instead of archive.apache.org
Why are the changes needed?
https://archive.apache.org/ discourages heavy use, and its rate limits can cause CI systems building Apache ORC to be banned.
How was this patch tested?
It builds from a clean repo
Was this patch authored or co-authored using generative AI tooling?
no