ORC-1811: Use the recommended closer.lua URL to download ORC format
#2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @williamhyun and @wgtmac |
kou
approved these changes
Dec 10, 2024
| @@ -137,7 +137,7 @@ endfunction() | |||
| # ---------------------------------------------------------------------- | |||
| # ORC Format | |||
| ExternalProject_Add (orc-format_ep | |||
| URL "https://dlcdn.apache.org/orc/orc-format-${ORC_FORMAT_VERSION}/orc-format-${ORC_FORMAT_VERSION}.tar.gz" | |||
| URL "https://www.apache.org/dyn/closer.lua/orc/orc-format-${ORC_FORMAT_VERSION}/orc-format-${ORC_FORMAT_VERSION}.tar.gz?action=download" | |||
| URL "https://archive.apache.org/dist/orc/orc-format-${ORC_FORMAT_VERSION}/orc-format-${ORC_FORMAT_VERSION}.tar.gz" | |||
There was a problem hiding this comment.
We can remove this archive.apache.org URL. The closer.lua URL redirects to the archive.apache.org URL automatically when the target file doesn't exist in https://dist.apache.org/repos/dist/release/orc/ .
There was a problem hiding this comment.
Sure, let me clean up this too.
|
Both the PR description and content are updated. Thank you, @kou . |
dongjoon-hyun
added a commit
that referenced
this pull request
Dec 10, 2024
This PR aims to use the ASF-recommended `closer.lua` URL instead of the direct `dlcdn` link or `archive` link. - https://infra.apache.org/release-download-pages.html#download-page > you can generate a direct download link using the following syntax: > http://www.apache.org/dyn/closer.lua/bar/foo/foo-5.5.1.zip?action=download To use the recommended download link in order to stabilize CIs. This is suggested from Arrow community. - #1830 (comment) - apache/arrow#44977 Pass the CIs. No. Closes #2081 from dongjoon-hyun/ORC-1811. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 28fe676) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to main/2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use the ASF-recommended
closer.luaURL instead of the directdlcdnlink orarchivelink.https://infra.apache.org/release-download-pages.html#download-page
Why are the changes needed?
To use the recommended download link in order to stabilize CIs.
This is suggested from Arrow community.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.