Skip to content

ORC-813: Upgrade ZSTD to 1.5.0#715

Merged
wgtmac merged 1 commit intoapache:mainfrom
dchristle:ZSTD150
Jun 10, 2021
Merged

ORC-813: Upgrade ZSTD to 1.5.0#715
wgtmac merged 1 commit intoapache:mainfrom
dchristle:ZSTD150

Conversation

@dchristle
Copy link
Contributor

What changes were proposed in this pull request?

This PR aims to upgrade ZSTD from 1.4.5 to 1.5.0.

Why are the changes needed?

This will bring in the latest performance improvements and bugfixes:

How was this patch tested?

Pass the CIs.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making a PR, @dchristle .

BTW, this PR updates Apache ORC C++ reader and writer while Apache ORC Java Reader and Writer is still behind because of the following. We need to verify that native ZSTD 1.5.0 works with old air compressor library.

      <dependency>
        <groupId>io.airlift</groupId>
        <artifactId>aircompressor</artifactId>
        <version>0.16</version>
      </dependency>

@dongjoon-hyun
Copy link
Member

cc @wgtmac

@wgtmac
Copy link
Member

wgtmac commented Jun 9, 2021

Thank you for making a PR, @dchristle .

BTW, this PR updates Apache ORC C++ reader and writer while Apache ORC Java Reader and Writer is still behind because of the following. We need to verify that native ZSTD 1.5.0 works with old air compressor library.

      <dependency>
        <groupId>io.airlift</groupId>
        <artifactId>aircompressor</artifactId>
        <version>0.16</version>
      </dependency>

I have checked the release note and haven't found any format incompatible issue.

@dongjoon-hyun
Copy link
Member

Thank you, @wgtmac . I'll leave this for you. Feel free to merge this for Apache ORC 1.7.0.

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM. Thanks @dchristle for contribution and @dongjoon-hyun for review!

@wgtmac wgtmac merged commit cb5388e into apache:main Jun 10, 2021
@dongjoon-hyun
Copy link
Member

@dchristle . I added you to the Apache ORC contributor group and assigned ORC-813 to you. Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments