Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize the log-stream Module in Logging #544

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

wtt40122
Copy link
Contributor

@wtt40122 wtt40122 commented Feb 8, 2025

Ⅰ. Describe what this PR did

Optimize log-stream module: Add request data comparison and remove lock usage

Ⅱ. Does this pull request fix one issue?

#543

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@gaoxh gaoxh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

Copy link
Contributor

@wodiwudi wodiwudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wodiwudi wodiwudi merged commit 934e4de into apache:master Feb 8, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants