Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11329. Update Ozone images to Rocky Linux-based runner #29

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Change apache/ozone:1.4.0 to use the latest apache/ozone-runner:20240729-jdk17-1 as base image. It has Rocky Linux instead of CentOS (EOL) and comes with updated third-party software.

(Similar PRs for other Ozone versions will follow.)

How was this patch tested?

  • Built image locally.
  • Started Docker Compose cluster and ran Freon.
  • Ran Ozone's xcompat acceptance test.

@adoroszlai adoroszlai requested a review from smengcl September 11, 2024 08:31
@adoroszlai adoroszlai self-assigned this Sep 12, 2024
Copy link

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai .

Do we need this change for latest branch as well?:

https://github.com/apache/ozone-docker/blob/latest/Dockerfile#L16

@adoroszlai
Copy link
Contributor Author

Thanks @smengcl for the review. I have pushed this to branch ozone-1.4.0-rocky, and similar changes for other versions, to trigger automated image builds. The new images are published with tags 1.4.0-rocky, ..., 1.0.0-rocky (see https://hub.docker.com/r/apache/ozone/tags)

Tested the new images with Ozone CI:
https://github.com/adoroszlai/ozone/actions/runs/10923350102

However, only xcompat and upgrade acceptance tests exercise these images. Other tests use ozone-runner with the current Ozone code.

Old Ozone smoketests may not be fully compatible with the new OS (e.g. usage of yum install in S3 tests in some old Ozone versions). We cannot fix that without overwriting parts of existing Ozone release in the Docker image -- I think we should avoid that.

I wonder which way we should proceed:

(1) keep the old images with existing content, and start using the new images with new tags, OR
(2) overwrite old images with new content?

@adoroszlai
Copy link
Contributor Author

Do we need this change for latest branch as well?:

Yes, latest should be patched (will do).

@adoroszlai
Copy link
Contributor Author

adoroszlai commented Sep 27, 2024

(1) keep the old images with existing content, and start using the new images with new tags,

@smengcl I've created apache/ozone#7241 to switch Ozone to Rocky Linux using new tags

@adoroszlai adoroszlai changed the base branch from ozone-1.4.0 to latest October 3, 2024 12:53
@adoroszlai
Copy link
Contributor Author

Thanks @smengcl for the review.

Pushed this to ozone-1.4.0-rocky, keep ozone-1.4.0 unchanged.

Do we need this change for latest branch as well?:

Yes, latest should be patched (will do).

Changed this PR to target latest.

@smengcl
Copy link

smengcl commented Oct 3, 2024

I wonder which way we should proceed:

(1) keep the old images with existing content, and start using the new images with new tags, OR (2) overwrite old images with new content?

@adoroszlai Sorry I didn't notice this question earlier. I think it is generally preferrable to take approach (1).

I see you already took the first approach by appending -rocky to the image tag. :D

@adoroszlai adoroszlai merged commit 38b0dbf into apache:latest Oct 3, 2024
1 check passed
@adoroszlai adoroszlai deleted the HDDS-11329_ozone-1.4.0 branch October 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants