HDDS-9271. SortDatanodes metric in OM getKeyInfo (#5280)

apache · Sep 12, 2023 · 8ee276c · 8ee276c
1 parent af72296
commit 8ee276c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
@@ -1955,7 +1955,8 @@ public OmKeyInfo getKeyInfo(OmKeyArgs args, String clientAddress)
               args.isForceUpdateContainerCacheFromSCM()));
 
       if (args.getSortDatanodes()) {
-        sortDatanodes(clientAddress, value);
+        captureLatencyNs(metrics.getGetKeyInfoSortDatanodesLatencyNs(),
+            () -> sortDatanodes(clientAddress, value));
       }
     }
     return value;

diff --git a/...op-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPerformanceMetrics.java b/...op-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPerformanceMetrics.java
@@ -74,6 +74,9 @@ public static void unregister() {
   @Metric(about = "ACLs check in getKeyInfo")
   private MutableRate getKeyInfoAclCheckLatencyNs;
 
+  @Metric(about = "Sort datanodes latency in getKeyInfo")
+  private MutableRate getKeyInfoSortDatanodesLatencyNs;
+
   @Metric(about = "resolveBucketLink latency in getKeyInfo")
   private MutableRate getKeyInfoResolveBucketLatencyNs;
 
@@ -142,6 +145,10 @@ public MutableRate getGetKeyInfoResolveBucketLatencyNs() {
     return getKeyInfoResolveBucketLatencyNs;
   }
 
+  public MutableRate getGetKeyInfoSortDatanodesLatencyNs() {
+    return getKeyInfoSortDatanodesLatencyNs;
+  }
+
   public void setForceContainerCacheRefresh(boolean value) {
     forceContainerCacheRefresh.add(value ? 1L : 0L);
   }