HDDS-9303. Display leader in table and highlight current node in OM web UI

[smitajoshi12]

What changes were proposed in this pull request?

SCM web UI displays the leader information on the webUI and it makes debugging easier. Need to do similar in Ozone Manager.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9303

How was this patch tested?

Manually

Old Ozone UI

New Changes

When it is Standalone with no data hiding OM Roles (HA) Table with ozone-ha

Running ozone

Exception Handling

[devmadhuu]

@smitajoshi12 thanks for working on this patch, PR description says need to show leader information in ozone manager webUI, however I think we already show LEADER and FOLLOWER info in OM Web UI, but in JSON format, so pls correct the PR description and PR title.

[dombizita]

thanks for working on this @smitajoshi12!

@smitajoshi12 thanks for working on this patch, PR description says need to show leader information in ozone manager webUI, however I think we already show LEADER and FOLLOWER info in OM Web UI, but in JSON format, so pls correct the PR description and PR title.

I agree with Devesh, the OM roles are already present in the OM UI, it was added by @ArafatKhan2198 in HDDS-6863. For me it looks good already as it is, all the necessary information is present there.
This new table that is nested in another table looks a bit weird for me, but maybe that's just for me :) If we want to have a change like this, maybe it should be moved to a new table, but I'm not sure if that would improve the OM UI that much. In the SCM UI it also presents this information in JSON format. Let me know what you think!

[smitajoshi12]

thanks for working on this @smitajoshi12!

@smitajoshi12 thanks for working on this patch, PR description says need to show leader information in ozone manager webUI, however I think we already show LEADER and FOLLOWER info in OM Web UI, but in JSON format, so pls correct the PR description and PR title.

I agree with Devesh, the OM roles are already present in the OM UI, it was added by @ArafatKhan2198 in HDDS-6863. For me it looks good already as it is, all the necessary information is present there. This new table that is nested in another table looks a bit weird for me, but maybe that's just for me :) If we want to have a change like this, maybe it should be moved to a new table, but I'm not sure if that would improve the OM UI that much. In the SCM UI it also presents this information in JSON format. Let me know what you think!

@dombizita
Hi ZIta,
Done Changes as suggested by you. Attached new Screenshot.

[devmadhuu]

thanks for working on this @smitajoshi12!

@smitajoshi12 thanks for working on this patch, PR description says need to show leader information in ozone manager webUI, however I think we already show LEADER and FOLLOWER info in OM Web UI, but in JSON format, so pls correct the PR description and PR title.

I agree with Devesh, the OM roles are already present in the OM UI, it was added by @ArafatKhan2198 in HDDS-6863. For me it looks good already as it is, all the necessary information is present there. This new table that is nested in another table looks a bit weird for me, but maybe that's just for me :) If we want to have a change like this, maybe it should be moved to a new table, but I'm not sure if that would improve the OM UI that much. In the SCM UI it also presents this information in JSON format. Let me know what you think!

@dombizita Hi ZIta, Done Changes as suggested by you. Attached new Screenshot.

@smitajoshi12 what is "tanle" format as you have mentioned in PR title. Is it by mistake ? Also PR description is not in line with what is being done in this patch. Also I agree with @dombizita , if this patch really needed as JSON format itself look fine and we want to keep any formatting or processing over OM UI as minimal as possible unless it is very much necessary. Can we keep same as in SCM webUI (in Json format) ? @dombizita @sumitagrawl pls suggest.

[ArafatKhan2198]

Thanks for the changes @smitajoshi12 for the OM-HA the table looks fine but what about when we have a standalone cluster will we want to display a table there as well, could you please attach a screenshot for that too.

[smitajoshi12]

Thanks for the changes @smitajoshi12 for the OM-HA the table looks fine but what about when we have a standalone cluster will we want to display a table there as well, could you please attach a screenshot for that too.

@ArafatKhan2198
Attached New Screenshot with Standalone cluster with no Data.

[sumitagrawl]

@smitajoshi12 Thanks for working over this, have few comments.

[sumitagrawl]

ep same as in SCM webUI (in Json format)

Giving as JSON format, and showing in tablular format is good. I think its just render the page with data and may not have much impact for table.
Already given few comments for STANDALONE, non-ratis or exception cases, this is hidden now. That may need resolve for showing.

[dombizita]

Thanks for working on this @smitajoshi12, please take a look at my comments!

[dombizita]

Thanks for updating you patch @smitajoshi12, I added a few comments. Also there are 2 lines that are longer than 30 characters, you can check it here: https://github.com/smitajoshi12/ozone/actions/runs/6657443633/job/18092176653

[sumitagrawl]

@smitajoshi12 Given few minor comments, please check

[adoroszlai]

/pending If there is exception, how the output looks? do still accessing roles[1],... can have issue over UI in exception case?

[github-actions]

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)

If there is exception, how the output looks? do still accessing roles[1],... can have issue over UI in exception case?

[smitajoshi12]

/ready
@adoroszlai

I have attached screenshot for Exception Handling.
There is no issue over UI in terms of Exception Handling.

[dombizita]

Thanks for updating your PR and its description @smitajoshi12, I have one more comment, please take a look at it. Otherwise it's looking good to me!

[dombizita]

Thanks for your continuous effort with this @smitajoshi12, could you take a look at my comments? Also please update the screenshots in the PR description with the changes.

[sumitagrawl]

@smitajoshi12 LGTM

[dombizita]

/ready

Blocking review request is removed.

[dombizita]

Thanks for working on this @smitajoshi12! Thank you for the review @devmadhuu, @ArafatKhan2198 and @sumitagrawl!