-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-9503. Migrate simple misc. integration tests to JUnit5 #5854
Conversation
Thanks @david1859168 for working on this. There are some conflicts with current Also, checkstyle reports the following problems:
https://github.com/david1859168/ozone/actions/runs/7296598719/job/19884620249 You can run checkstyle locally by:
|
5b388fa
to
339c3cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @david1859168 for updating the patch.
...op-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestContainerOperations.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestBlockTokensCLI.java
Outdated
Show resolved
Hide resolved
.../integration-test/src/test/java/org/apache/hadoop/ozone/TestContainerBalancerOperations.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestBlockTokens.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestBlockTokens.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestBlockTokens.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestBlockTokens.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @david1859168 for updating the patch again.
.../integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestContainerReportWithKeys.java
Outdated
Show resolved
Hide resolved
.../integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestContainerReportWithKeys.java
Outdated
Show resolved
Hide resolved
Thanks again @david1859168 for the patch. |
) (cherry picked from commit b33768e)
What changes were proposed in this pull request?
HDDS-9503. Migrate simple misc. integration tests to JUnit5
Please describe your PR in detail:
Migrate the following test classes from Junit4 to JUnit5 by following the parent JIRA [HDDS-6729. Migrate tests to JUnit5]
hadoop-ozone/fault-injection-test/mini-chaos-tests/src/test/java/org/apache/hadoop/ozone/TestMiniChaosOzoneCluster.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/storage/TestCommitWatcher.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestBlockTokens.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestBlockTokensCLI.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestContainerBalancerOperations.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestContainerOperations.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestContainerStateMachineIdempotency.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestMiniOzoneOMHACluster.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/debug/TestLeaseRecoverer.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/fsck/TestContainerMapper.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestContainerReportWithKeys.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestSecretKeysApi.java
How was this patch tested?
Tested in Intellij.