Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-10028. Simplify Maven cache for dependencies in CI #5889

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Dec 29, 2023

What changes were proposed in this pull request?

  • license check should use Maven cache for dependencies.
  • Use explicit cache/restore in all checks except build. This avoids the need for separate cache keys in concurrent checks, since only build will save cache.
  • Specify path exception to avoid the need to explicitly delete Ozone artifacts before cache upload.

https://issues.apache.org/jira/browse/HDDS-10028

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/7355754873

@adoroszlai adoroszlai added the CI label Dec 29, 2023
@adoroszlai adoroszlai self-assigned this Dec 29, 2023
@adoroszlai adoroszlai changed the title HDDS-10028. Use Maven cache for dependencies in license check HDDS-10028. Simplify Maven cache for dependencies in CI Dec 29, 2023
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@adoroszlai adoroszlai merged commit 25886f3 into apache:master Jan 2, 2024
39 checks passed
@adoroszlai adoroszlai deleted the HDDS-10028 branch January 2, 2024 07:38
@adoroszlai
Copy link
Contributor Author

Thanks @szetszwo for the review.

adoroszlai added a commit to adoroszlai/ozone that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants