HDDS-10262. Encapsulate SnapshotCache inside OmSnapshotManager #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hemantk-12 please take a look at this PR |
hemantk-12
reviewed
Feb 2, 2024
There was a problem hiding this comment.
Thanks @Cyrill for the improvements.
Overall looks good to me. Left some inline comment.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java
Show resolved
Hide resolved
|
@smengcl can you please also take a look? |
# Conflicts: # hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/service/TestKeyDeletingService.java
hemantk-12
reviewed
Feb 5, 2024
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
Outdated
Show resolved
Hide resolved
hemantk-12
reviewed
Feb 7, 2024
There was a problem hiding this comment.
LGTM.
@smengcl and @aswinshakil, please take a look as well.
aswinshakil
reviewed
Feb 8, 2024
There was a problem hiding this comment.
Thanks @Cyrill for this effort of refactoring. Most of the changes looks good to me. I have a comment inline.
| /** | ||
| * Parent instance whose callback will be triggered upon this RC closure. | ||
| */ | ||
| private final U parentWithCallback; |
There was a problem hiding this comment.
I'm fine with leaving the unused field, though I strongly believe the callback should not be a part of the class generics.
There was a problem hiding this comment.
Returned back the field.
|
Are we okay to merge this pr? Who should I ask to do that? |
hemantk-12
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDDS-10262. Encapsulate SnapshotCache inside OmSnapshotManager
Changes made:
SnapshotCacheis now used purely inOmSnapshotManagerand not exposed outside.Previous calls to
SnapshotCacheare now changed toOmSnapshotManager.Explicit parameter "
skipActiveCheck" was removed, active state check is done implicitly.Also changed the generics in snapshot's ReferenceCounted returned value to get rid of type casts all over the codebase.
Removed unused parameter from ReferenceCounted class.
Reasoning
SnapshotCacheis now hidden from the world and any further refactoring to it should be easier.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10262
How was this patch tested?
Existing unit tests. There was no new functionality added.