Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-10387. Fix parameter number warning in KeyOutputStream and the related classes #6225

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

szetszwo
Copy link
Contributor

What changes were proposed in this pull request?

We fix the @SuppressWarnings({"parameternumber", "squid:S00107"}) in

  • KeyOutputStream
  • BlockOutputStreamEntry
  • BlockOutputStreamEntryPool
  • ECBlockOutputStreamEntry
  • ECBlockOutputStreamEntryPool

What is the link to the Apache JIRA

HDDS-10387

How was this patch tested?

By the existing tests.

Copy link
Contributor

@nandakumar131 nandakumar131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @szetszwo for working on this.

@adoroszlai adoroszlai merged commit c672453 into apache:master Feb 20, 2024
35 checks passed
@adoroszlai
Copy link
Contributor

Thanks @szetszwo for the patch, @nandakumar131 for the review.

@szetszwo
Copy link
Contributor Author

@nandakumar131, @adoroszlai , thanks a lot for reviewing this!

xichen01 pushed a commit to xichen01/ozone that referenced this pull request Apr 11, 2024
xichen01 pushed a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants