Revert "HDDS-10384. RPC client Reusing thread resources. (#6270)" #6277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 84c6e4d.
szetszwo
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
+1 the change looks good.
@adoroszlai , thanks a lot for submitting this pull request!
@xichen01 , we should see why the tests are failing. It might be due to shutdownNow(). Previously, responseExecutor won't be shut down until it has finished.
xichen01
approved these changes
Feb 27, 2024
Yes, maybe some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This reverts commit 84c6e4d, because it introduced flakiness in the write path.
How was this patch tested?
Checked repeated test runs before HDDS-10384, with HDDS-10384 and after reverting it. Write tests like
TestFreonWithPipelineDestroy,TestSecureOzoneRpcClient#testPutKeyRatisThreeNodesParalleletc. fail frequently with HDDS-10384, pass before that and after revert.HDDS-10384 failing: https://github.com/adoroszlai/ozone/actions/runs/8050504234
revert passing: https://github.com/adoroszlai/ozone/actions/runs/8052736373