Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-10331. Rename Java constants of ex-DFS config keys #6290

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

sarvekshayr
Copy link
Contributor

@sarvekshayr sarvekshayr commented Feb 28, 2024

What changes were proposed in this pull request?

HDDS-815 (#6274) renamed config keys prefixed with dfs., which was inherited from Ozone's Hadoop backgrounds. The goal of this task is to rename the corresponding Java constants, both for config key and for default value.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10331

How was this patch tested?

Got a clean CI run.

@sarvekshayr
Copy link
Contributor Author

@adoroszlai @tanvipenumudy Could you please review this?

Copy link
Contributor

@myskov myskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But HDDS (Hadoop Distributed Data Store) is also a term from hadoop's background...
However, this patch makes config names consistent

@adoroszlai
Copy link
Contributor

But HDDS (Hadoop Distributed Data Store) is also a term from hadoop's background...

HDDS may refer to Hadoop, but is not used in Hadoop since Ozone moved from sub-project to top-level project. The prefix dfs. is widely used for Hadoop's own config keys.

@adoroszlai adoroszlai merged commit 01f8d62 into apache:master Feb 28, 2024
36 checks passed
@adoroszlai
Copy link
Contributor

Thanks @sarvekshayr for the patch, @myskov for the review.

jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Mar 15, 2024
(cherry picked from commit 01f8d62)
Change-Id: I299de409e9549ecb9bea2734076d5ded227dd4dd
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants