Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-10552. Downgrade Surefire to 3.0.0-M4 #6406

Merged
merged 1 commit into from
Mar 20, 2024
Merged

HDDS-10552. Downgrade Surefire to 3.0.0-M4 #6406

merged 1 commit into from
Mar 20, 2024

Conversation

adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Mar 19, 2024 •
edited
Loading

What changes were proposed in this pull request?

Workaround for SUREFIRE-1815, which affects 3.0.0-M5, by downgrading to M4. Cannot upgrade to M6 or newer, because forks are not killed correctly (SUREFIRE-1722, HDDS-10174) as of 3.2.5.

SUREFIRE-1815 causes intermittent fork timeout due to not being able to interrupt e.g. container scanner thread:

"main" 
   java.lang.Thread.State: WAITING
        at java.lang.Object.wait(Native Method)
        at java.lang.Thread.join(Thread.java:1257)
        at java.lang.Thread.join(Thread.java:1331)
        at org.apache.hadoop.ozone.container.ozoneimpl.AbstractBackgroundContainerScanner.shutdown(AbstractBackgroundContainerScanner.java:149)
        at org.apache.hadoop.ozone.container.ozoneimpl.BackgroundContainerDataScanner.shutdown(BackgroundContainerDataScanner.java:143)
        at org.apache.hadoop.ozone.container.ozoneimpl.BackgroundContainerDataScanner.shutdown(BackgroundContainerDataScanner.java:135)
        at org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer.stopContainerScrub(OzoneContainer.java:406)
        at org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer.stop(OzoneContainer.java:482)
        at org.apache.hadoop.ozone.container.common.statemachine.DatanodeStateMachine.close(DatanodeStateMachine.java:447)
        at org.apache.hadoop.ozone.container.upgrade.TestDatanodeUpgradeToSchemaV3.teardown(TestDatanodeUpgradeToSchemaV3.java:124)

"ContainerDataScanner(/tmp/junit2150526860730266625/7d8911bf-6e2c-4707-8262-2995b687ba41/hdds)" 
   java.lang.Thread.State: TIMED_WAITING
        at java.lang.Thread.sleep(Native Method)
        at org.apache.hadoop.ozone.container.ozoneimpl.AbstractBackgroundContainerScanner.handleRemainingSleep(AbstractBackgroundContainerScanner.java:131)
        at org.apache.hadoop.ozone.container.ozoneimpl.AbstractBackgroundContainerScanner.runIteration(AbstractBackgroundContainerScanner.java:98)
        at org.apache.hadoop.ozone.container.ozoneimpl.AbstractBackgroundContainerScanner.run(AbstractBackgroundContainerScanner.java:57)

https://issues.apache.org/jira/browse/HDDS-10552

How was this patch tested?

Already verified that M4 correctly kills forks when needed (#6075).

Regular CI:
https://github.com/adoroszlai/ozone/actions/runs/8341980137

Flaky test check:
https://github.com/adoroszlai/ozone/actions/runs/8342506669 (unit)
https://github.com/adoroszlai/ozone/actions/runs/8342512159 (integration)

@adoroszlai adoroszlai added the CI label Mar 19, 2024
@adoroszlai adoroszlai self-assigned this Mar 19, 2024
@adoroszlai adoroszlai mentioned this pull request Mar 19, 2024
Merged
@adoroszlai adoroszlai requested a review from sumitagrawl March 19, 2024 14:53
hemantk-12
hemantk-12 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@hemantk-12 hemantk-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai for the patch.

LGTM.

@adoroszlai adoroszlai added the dependencies Pull requests that update a dependency file label Mar 20, 2024
@adoroszlai adoroszlai merged commit ca8f1f7 into apache:master Mar 20, 2024
36 checks passed
@adoroszlai adoroszlai deleted the HDDS-10552 branch March 20, 2024 09:44
@adoroszlai
Copy link
Contributor Author

Thanks @hemantk-12 for the review.

myskov pushed a commit to myskov/ozone that referenced this pull request Apr 3, 2024
@adoroszlai
HDDS-10552. Downgrade Surefire to 3.0.0-M4 (apache#6406)
290c6fc 
(cherry picked from commit ca8f1f7)
myskov pushed a commit to myskov/ozone that referenced this pull request Apr 3, 2024
@adoroszlai
HDDS-10552. Downgrade Surefire to 3.0.0-M4 (apache#6406)
e606e95 
(cherry picked from commit ca8f1f7)
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Apr 17, 2024
@adoroszlai @xichen01
HDDS-10552. Downgrade Surefire to 3.0.0-M4 (apache#6406)
94e743b 
(cherry picked from commit ca8f1f7)
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Apr 18, 2024
@adoroszlai @xichen01
HDDS-10552. Downgrade Surefire to 3.0.0-M4 (apache#6406)
cc73e01 
(cherry picked from commit ca8f1f7)
@xichen01 xichen01 mentioned this pull request Apr 18, 2024
Merged
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Apr 23, 2024
@adoroszlai @xichen01
HDDS-10552. Downgrade Surefire to 3.0.0-M4 (apache#6406)
6a31ccd 
(cherry picked from commit ca8f1f7)
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Oct 1, 2024
@adoroszlai @xichen01
HDDS-10552. Downgrade Surefire to 3.0.0-M4 (apache#6406)
d889984 
(cherry picked from commit ca8f1f7)
@xichen01 xichen01 mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemantk-12 hemantk-12 hemantk-12 approved these changes

@sodonnel sodonnel Awaiting requested review from sodonnel

@aswinshakil aswinshakil Awaiting requested review from aswinshakil

@sumitagrawl sumitagrawl Awaiting requested review from sumitagrawl

Assignees

@adoroszlai adoroszlai

Labels
CI dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adoroszlai @hemantk-12