HDDS-9039. Removed the pause and wait in RocksDB compaction when tarball creation is in progress #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all creation is in progress
swamirishi
approved these changes
May 13, 2024
|
Thanks @swamirishi for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 23, 2024
…all creation is in progress (apache#6552)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As part of the change #4680 (comment), it was asked to add sequence number to compaction logs (HDDS-8652) and later pause in the RocksDB compaction when tarball creation is in progress (HDDS-9004 and HDDS-9064). These changes were valid when a text file was used to store compaction log entries.
After HDDS-9311, compaction logs were migrated to the RocksDB column family. Now we can simply rely on RocksDB's synchronization. Either the compaction entry will be present in the compactionLog columnFamily or not in the snapshot of the ActiveFS depending on the order of compaction entry append and checkpoint creation.
This change is to remove the wait and notify logic between RocksDB's compaction and tarball creation.
What is the link to the Apache JIRA
HDDS-9039
How was this patch tested?
Updated existing unit tests.