-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-10435. Support S3 object tags for existing requests #6607
Merged
+1,071
−102
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c8105e9
HDDS-10435. Support S3 object tags for existing requests
ivandika3 453af1f
Move length validations before regex validations
ivandika3 805183e
Add FSO bucket layout to testCreateKeyWithMetadataAndTags
ivandika3 c2cdc49
Add FSO bucket layout to testMultipartUploadWithTags
ivandika3 d02926c
Remove unnecessary set tags operation in OMKeyCommitRequestWithFSO
ivandika3 4e9bb13
Fix test paremeters
ivandika3 b9726eb
Separate test methods for failure cases
ivandika3 6fb9131
Acceptance test for too many tags
ivandika3 83a592d
Check OM version before creating key with tags
ivandika3 56ba576
Merge branch 'master' into HDDS-10435
ivandika3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Acceptance test for too many tags
commit 6fb913181e122610055615c6da9d61a63023709f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: might make sense to check the case with a tags list size of more than 10 too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.