Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-10867. Clean Up Unnecessary Logs in Recon. #6703

Merged
merged 2 commits into from
May 28, 2024

Conversation

ArafatKhan2198
Copy link
Contributor

What changes were proposed in this pull request?

Set the log levels of various background tasks in Recon to debug. These tasks were previously filling the Recon logs unnecessarily, as they are only needed for debugging in rare cases. Now, they will not flood the Recon logs after every delta update sync as they did before.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10867

How was this patch tested?

Verified the logs manually.

@ArafatKhan2198
Copy link
Contributor Author

@devmadhuu @dombizita Could you please look at this, small patch.

Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArafatKhan2198, the changes are looking good to me, it makes sense to change the log level for these logs.

@dombizita dombizita requested a review from devmadhuu May 21, 2024 11:42
Copy link
Contributor

@devmadhuu devmadhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArafatKhan2198 for working on this patch. Kindly check the following sync tasks:

  1. ContainerKeyMapperTask
  2. OmTableInsightTask
  3. ContainerHealthTask
  4. PipelineSyncTask

@ArafatKhan2198 ArafatKhan2198 requested a review from devmadhuu May 22, 2024 17:02
@ArafatKhan2198
Copy link
Contributor Author

@devmadhuu please take a look!

Copy link
Contributor

@devmadhuu devmadhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArafatKhan2198 for working on this patch. Changes LGTM +1

@devmadhuu devmadhuu merged commit 5179fc3 into apache:master May 28, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants