Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11198. Fix Typescript configs for Recon #6961

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

devabhishekpal
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-11198. Fix Typescript configs for Ozone Recon

Please describe your PR in detail:

  • Currently the tsconfig is not up to standard recommended by TypeScript. We are explicitly specifying the complete path.
  • While the builds happen properly, but the editor/IDE cannot properly resolve the modules
  • This PR fixes the issue by properly specify the path relative to the baseUrl
  • It also adds a .vscode configuration folder to help new contributors setup their editor/environment out of the box.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11198

How was this patch tested?

The patch was tested manually by running build, as well as checking if the resolution errors go away after changing the settings

Copy link
Contributor

@ArafatKhan2198 ArafatKhan2198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Improvements @devabhishekpal
LGTM !

@ArafatKhan2198 ArafatKhan2198 changed the title HDDS-11198. Fix Typescript configs for Recon HDDS-11198. Fix Typescript configs for Recon Jul 18, 2024
@ArafatKhan2198
Copy link
Contributor

@smitajoshi12 Can you also take a look.

@adoroszlai adoroszlai merged commit daab2b3 into apache:master Jul 18, 2024
33 of 34 checks passed
@adoroszlai
Copy link
Contributor

Thanks @devabhishekpal for the patch, @ArafatKhan2198 for the review.

@smitajoshi12 please let @devabhishekpal know if there are any concerns about the change.

@smitajoshi12
Copy link
Contributor

It looks good to me

@devabhishekpal devabhishekpal deleted the HDDS-11198 branch July 19, 2024 06:44
errose28 added a commit to errose28/ozone that referenced this pull request Jul 30, 2024
…-delete

* HDDS-10239-container-reconciliation: (184 commits)
  HDDS-10373. Implement framework for capturing Merkle Tree Metrics. (apache#6864)
  HDDS-11188. Initial setup for new UI layout and enable users to switch to new UI (apache#6953)
  HDDS-11120. Rich rebalancing status info (apache#6911)
  HDDS-11187. Fix Event Handling in Recon OMDBUpdatesHandler to Prevent ClassCastException. (apache#6950)
  HDDS-11213. Bump commons-daemon to 1.4.0 (apache#6971)
  HDDS-11212. Bump commons-net to 3.11.1 (apache#6973)
  HDDS-11211. Bump assertj-core to 3.26.3 (apache#6972)
  HDDS-11210. Bump log4j2 to 2.23.1 (apache#6970)
  HDDS-11150. Recon Overview page crashes due to failed API Calls (apache#6944)
  HDDS-11183. Keys from DeletedTable and DeletedDirTable of AOS should be deleted on batch operation while creating a snapshot (apache#6946)
  HDDS-11198. Fix Typescript configs for Recon (apache#6961)
  HDDS-11180. Simplify HttpServer2#inferMimeType return statement (apache#6963)
  HDDS-11194. OM missing audit log for upgrade (apache#6958)
  HDDS-10389. Implement a search feature for users to locate open keys within the Open Keys Insights section. (apache#6231)
  HDDS-10561. Dashboard for delete key metrics (apache#6948)
  HDDS-11192. Increase SPNEGO URL test coverage (apache#6956)
  HDDS-11179. DBConfigFromFile#readFromFile result of toIOException not thrown (apache#6957)
  HDDS-11186. First container log missing from bundle (apache#6952)
  HDDS-10844. Clarify snapshot create error message. (apache#6955)
  HDDS-11166. Switch to Rocky Linux-based ozone-runner (apache#6942)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants