Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11215. Quota count can go wrong when double buffer flush takes time #6978

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

sumitagrawl
Copy link
Contributor

What changes were proposed in this pull request?

bucketInfo can have incorrect count, and even can go -ve value. This is as DirectoryDeletingService keeps sending purgeDirectory request till rocksdb delectedDirectoryTable is not flushed with deletion. For the fix,

  • Cache is added for directoryTable and fileTable marking the key is deleted
  • in directoryDeletetingService, applicable list to delete directory / files are obtained with check from cache if deleted

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11215

How was this patch tested?

  • Integration test covering scenario (reproduced without fix)

@sadanand48 sadanand48 marked this pull request as ready for review July 22, 2024 15:22
Copy link
Contributor

@sadanand48 sadanand48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sumitagrawl for finding this issue. patch LGTM

@sadanand48 sadanand48 merged commit 19f9afb into apache:master Jul 24, 2024
50 checks passed
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Jul 26, 2024
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Jul 26, 2024
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Jul 26, 2024
ptlrs pushed a commit to ptlrs/ozone that referenced this pull request Mar 8, 2025
…lush takes time. (apache#6978) (apache#81)

(cherry picked from commit 19f9afb)

Co-authored-by: Sumit Agrawal <sumit.jecrc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants