Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11225. Increase ipc.server.read.threadpool.size #7007

Merged
merged 3 commits into from
Aug 2, 2024
Merged

HDDS-11225. Increase ipc.server.read.threadpool.size #7007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80a8903
HDDS-11225. Increase ipc.server.read.threadpool.size
jojochuang Jul 29, 2024
3828801
Fix checkstyle
jojochuang Jul 30, 2024
b8e3543
Updtate configuration property description
jojochuang Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions hadoop-hdds/common/src/main/resources/ozone-default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,15 @@
The number of RPC handler threads for OM service endpoints.
</description>
</property>
<property>
<name>ozone.om.read.threadpool</name>
<value>10</value>
<tag>OM, PERFORMANCE</tag>
<description>
The number of threads in RPC server reading from the socket for OM service endpoints.
This config overrides Hadoop configuration "ipc.server.read.threadpool.size" for Ozone Manager.
</description>
</property>
<property>
<name>ozone.om.http-address</name>
<value>0.0.0.0:9874</value>
Expand Down
3 changes: 3 additions & 0 deletions hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ private OMConfigKeys() {
public static final String OZONE_OM_HANDLER_COUNT_KEY =
"ozone.om.handler.count.key";
public static final int OZONE_OM_HANDLER_COUNT_DEFAULT = 100;
public static final String OZONE_OM_READ_THREADPOOL_KEY =
"ozone.om.read.threadpool";
public static final int OZONE_OM_READ_THREADPOOL_DEFAULT = 10;

public static final String OZONE_OM_INTERNAL_SERVICE_ID =
"ozone.om.internal.service.id";
Expand Down
18 changes: 11 additions & 7 deletions hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,8 @@
import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_KERBEROS_PRINCIPAL_KEY;
import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_METRICS_SAVE_INTERVAL;
import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_METRICS_SAVE_INTERVAL_DEFAULT;
import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_READ_THREADPOOL_DEFAULT;
import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_READ_THREADPOOL_KEY;
import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_S3_GPRC_SERVER_ENABLED;
import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_S3_GRPC_SERVER_ENABLED_DEFAULT;
import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_NAMESPACE_STRICT_S3;
Expand Down Expand Up @@ -1241,8 +1243,6 @@ private RPC.Server getRpcServer(OzoneConfiguration conf) throws IOException {
OzoneNetUtils.getAddressWithHostNameLocal(omNodeRpcAddr);
}

final int handlerCount = conf.getInt(OZONE_OM_HANDLER_COUNT_KEY,
OZONE_OM_HANDLER_COUNT_DEFAULT);
RPC.setProtocolEngine(configuration, OzoneManagerProtocolPB.class,
ProtobufRpcEngine.class);

Expand Down Expand Up @@ -1271,8 +1271,8 @@ private RPC.Server getRpcServer(OzoneConfiguration conf) throws IOException {
ReconfigureProtocolService.newReflectiveBlockingService(
reconfigureServerProtocol);

return startRpcServer(configuration, omNodeRpcAddr, omService,
omInterService, omAdminService, reconfigureService, handlerCount);
return startRpcServer(conf, omNodeRpcAddr, omService,
omInterService, omAdminService, reconfigureService);
}

/**
Expand All @@ -1285,24 +1285,28 @@ private RPC.Server getRpcServer(OzoneConfiguration conf) throws IOException {
* (OMInterServiceProtocolPB impl)
* @param reconfigureProtocolService RPC protocol for reconfigure
* * (ReconfigureProtocolPB impl)
* @param handlerCount RPC server handler count
* @return RPC server
* @throws IOException if there is an I/O error while creating RPC server
*/
private RPC.Server startRpcServer(OzoneConfiguration conf,
InetSocketAddress addr, BlockingService clientProtocolService,
BlockingService interOMProtocolService,
BlockingService omAdminProtocolService,
BlockingService reconfigureProtocolService,
int handlerCount)
BlockingService reconfigureProtocolService)
throws IOException {

final int handlerCount = conf.getInt(OZONE_OM_HANDLER_COUNT_KEY,
OZONE_OM_HANDLER_COUNT_DEFAULT);
final int readThreads = conf.getInt(OZONE_OM_READ_THREADPOOL_KEY,
OZONE_OM_READ_THREADPOOL_DEFAULT);

RPC.Server rpcServer = preserveThreadName(() -> new RPC.Builder(conf)
.setProtocol(OzoneManagerProtocolPB.class)
.setInstance(clientProtocolService)
.setBindAddress(addr.getHostString())
.setPort(addr.getPort())
.setNumHandlers(handlerCount)
.setNumReaders(readThreads)
.setVerbose(false)
.setSecretManager(delegationTokenMgr)
.build());
Expand Down