HDDS-11764. Fix initiating DocumentBuilderFactory performance problem. #7462
+54
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Thanks @juncevich for working on this. Please check CI run for failures: https://github.com/juncevich/ozone/actions/runs/11940547308
Comment on lines
62
to
70
| NodeSchemaManager cachedInstance = cache.get(schemaFile); | ||
| if (cachedInstance == null) { | ||
| instance = new NodeSchemaManager(); | ||
| instance.init(schemaFile); | ||
| cache.put(schemaFile, instance); | ||
| return instance; | ||
| } else { | ||
| return cachedInstance; | ||
| } |
There was a problem hiding this comment.
This is not thread-safe. Use cache.computeIfAbsent() if NodeSchemaManager.init() has no side-effects.
There was a problem hiding this comment.
Thanks, will fix.
|
Looking at stack trace in the screenshot attached to HDDS-11764, I think this is fixed by #6434. |
|
Yep. It looks like you're right. |
|
Will test and this PR close if the problem will solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDDS-11764. Fix initiating DocumentBuilderFactory performance problem.
Cache initiating DocumentBuilderFactory and NodeSchemaManager to ip
Link to Jira task: HDDS-11764
Patch tested only by performance tests.