Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11774. Adding listing metadata flag to resolve client incompatibility for listing #7468

Closed
wants to merge 1 commit into from

Conversation

swamirishi
Copy link
Contributor

What changes were proposed in this pull request?

Creating a generic metadata map in the OMRequest to deal with client version incompatibility. Setting a key in the client request to the map for server to act on the basis of the value set by the client.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11774

How was this patch tested?

Planning to add a compatibility test for this.

…ility for listing

Change-Id: I11a488433f7778c696e0830e1cda11f82ae983b3
@fapifta
Copy link
Contributor

fapifta commented Nov 23, 2024

QQ, why aren't we bump the client version instead to (client supports server side liststatus limits or something like that), so that we can identify older clients that does not know about/respect the server side limit, and then we can treat these clients from the server side?

At least my understanding is that about the current draft that it pushes this client information via a request metadata instead of with the client's version, but please correct me if I am wrong.

@swamirishi
Copy link
Contributor Author

swamirishi commented Nov 24, 2024

QQ, why aren't we bump the client version instead to (client supports server side liststatus limits or something like that), so that we can identify older clients that does not know about/respect the server side limit, and then we can treat these clients from the server side?

At least my understanding is that about the current draft that it pushes this client information via a request metadata instead of with the client's version, but please correct me if I am wrong.

You are right @fapifta we can achieve this by a client version bump and that is eventual goal. But because our request feature validator is broken we cannot bump up our client version. We already have a patch upstream which fixes that #6932 . I thought to have a patch in the interim. But after discussing about this offline with @errose28 @prashantpogde @umamaheswararao @swagle we came to a conclusion to abandon this change and work on merging the request feature validator fix and perform a client version bump up instead.

@swamirishi swamirishi closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants