HDDS-11975. wrap TermIndex in ExecutionContext #7602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Dec 22, 2024
There was a problem hiding this comment.
Thanks @sumitagrawl for the patch.
I think we can keep using TermIndex even if the index is not generated by Ratis, similar to how it's used currently when Ratis is disabled in OM. TermIndex is just an interface, we can define custom implementation, if additional data is needed for generating our own index. Thus we could avoid wrapping it in yet another object, and skip refactoring a bunch of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Wrap TermIndex in ExecutionContext. ExecutionContext.getIndex() will have same value as termIndex.
There is no logic change.
Later, with below Jira, dependency with ratisIndex will be removed,
https://issues.apache.org/jira/browse/HDDS-11901
Parent Jira:
https://issues.apache.org/jira/browse/HDDS-11897
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11975
How was this patch tested?
Existing testcase