HDDS-11951. Enable sortpom in hadoop-hdds sub-modules : annotations, client, common & config. #7631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client, common & config.
adoroszlai
approved these changes
Jan 2, 2025
Comment on lines
+31
to
+32
| <maven.test.skip>true</maven.test.skip> | ||
| <!-- no tests in this module so far --> |
There was a problem hiding this comment.
In the next sub-task under HDDS-11905 please include this trivial change:
Suggested change
| <maven.test.skip>true</maven.test.skip> | |
| <!-- no tests in this module so far --> | |
| <!-- no tests in this module so far --> | |
| <maven.test.skip>true</maven.test.skip> |
There was a problem hiding this comment.
Sure, will fix this in the next PR.
|
Thanks @adoroszlai for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable sortpom in hadoop-hdds sub-modules :
annotations,client,common&config.Sortpom plugin was added as part of #7555.
This PR enables the plugin for
hadoop-hddssub-modules. (part 1)Sorting all the sub-modules under
hadoop-hddscreates a big change, which will be hard to review. So, breaking this into multiple PRs.This PR also sorts the pom of
hadoop-hddsand the following sub-modules.What is the link to the Apache JIRA
HDDS-11951
How was this patch tested?
Manually tested by adding out of order property.
hadoop-hdds/pom.xmlhadoop-hdds/annotations/pom.xmlhadoop-hdds/client/pom.xmlhadoop-hdds/common/pom.xmlhadoop-hdds/config/pom.xml