Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-12139. Refactor TestSnapshotChainRepair #7752

Merged
merged 17 commits into from
Jan 28, 2025

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  • reduce duplication
  • avoid assertTrue
  • verify lack of DB write in error cases

Please see individual commits for steps/details.

https://issues.apache.org/jira/browse/HDDS-12139

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/12965083999

@adoroszlai adoroszlai self-assigned this Jan 25, 2025
Copy link
Contributor

@peterxcli peterxcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this perfect refactor. LGTM!

@nandakumar131
Copy link
Contributor

Thanks @adoroszlai for the contribution and thanks to @peterxcli for the review.

@nandakumar131 nandakumar131 merged commit f1b59f1 into apache:master Jan 28, 2025
29 checks passed
@adoroszlai adoroszlai deleted the HDDS-12139 branch January 28, 2025 06:25
@adoroszlai
Copy link
Contributor Author

Thanks @nandakumar131, @peterxcli for the review.

nandakumar131 pushed a commit to nandakumar131/ozone that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants