Fix that field nullability affects write #24
Merged
+121
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Nov 11, 2024
| } | ||
|
|
||
| public void write(byte[] bytes) throws Exception { | ||
| public void write(byte[] bytes, boolean needCheckSchema) throws Exception { |
There was a problem hiding this comment.
record_batch in #write_pandas is converted from table schema, so it is unnecessary to check it.
JingsongLi
reviewed
Nov 11, 2024
| return true; | ||
| } | ||
|
|
||
| private boolean checkField(Field expected, Field actual) { |
yuzelin
added a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 00af9ad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The case is:
pkis non-null from Paimon;pk not nullstrictly , sowith pa.RecordBatchStreamWriter(stream, self._arrow_schema) as writerwill throw error.Fix:
pa.RecordBatchStreamWriteruse data's schema, and let java codes to check field (ignore nullability)Tests
API and Format
Documentation