Fixed the problem of abnormality when using TIMESTAMP_LTZ(3) field as filter condition #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @groobyming . Thanks for the contribution. As you're fixing an issue, please also add related tests so we can confirm that the issue is indeed solved. |
@tsreaper Ok, I will add some tests |
groobyming
force-pushed
the
fix_filter_timestampltz_error
branch
from
b20c31c to
a20e492
Compare
|
@tsreaper Added some test cases, please help review these changes |
…field type is TIMESTAMP_LTZ(3)
groobyming
force-pushed
the
fix_filter_timestampltz_error
branch
from
a20e492 to
d38ff65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem of abnormality when using TIMESTAMP_LTZ(3) field as filter condition