Skip to content

Commit

Permalink
[core] Remove useless fs.allow-hadoop-fallback in catalog options
Browse files Browse the repository at this point in the history
  • Loading branch information
JingsongLi committed Sep 25, 2024
1 parent cba8447 commit 763f469
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 16 deletions.
6 changes: 0 additions & 6 deletions docs/layouts/shortcodes/generated/catalog_configuration.html
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,6 @@
<td>Integer</td>
<td>Configure the size of the connection pool.</td>
</tr>
<tr>
<td><h5>fs.allow-hadoop-fallback</h5></td>
<td style="word-wrap: break-word;">true</td>
<td>Boolean</td>
<td>Allow to fallback to hadoop File IO when no file io found for the scheme.</td>
</tr>
<tr>
<td><h5>lineage-meta</h5></td>
<td style="word-wrap: break-word;">(none)</td>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,6 @@ public class CatalogOptions {
.defaultValue(Duration.ofMinutes(8))
.withDescription("The maximum time to wait for acquiring the lock.");

public static final ConfigOption<Boolean> FS_ALLOW_HADOOP_FALLBACK =
key("fs.allow-hadoop-fallback")
.booleanType()
.defaultValue(true)
.withDescription(
"Allow to fallback to hadoop File IO when no file io found for the scheme.");

public static final ConfigOption<Integer> CLIENT_POOL_SIZE =
key("client-pool-size")
.intType()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ public void testCatalogOptionsInheritAndOverride() throws Exception {
+ "'table-default.opt1'='value1', "
+ "'table-default.opt2'='value2', "
+ "'table-default.opt3'='value3', "
+ "'fs.allow-hadoop-fallback'='false',"
+ "'lock.enabled'='false'"
+ ")",
path));
Expand All @@ -134,7 +133,6 @@ public void testCatalogOptionsInheritAndOverride() throws Exception {
assertThat(tableOptions).containsEntry("opt1", "value1");
assertThat(tableOptions).containsEntry("opt2", "value2");
assertThat(tableOptions).containsEntry("opt3", "value3");
assertThat(tableOptions).doesNotContainKey("fs.allow-hadoop-fallback");
assertThat(tableOptions).doesNotContainKey("lock.enabled");

// check table options override catalog's
Expand All @@ -147,7 +145,6 @@ public void testCatalogOptionsInheritAndOverride() throws Exception {
assertThat(tableOptions).containsEntry("opt1", "value1");
assertThat(tableOptions).containsEntry("opt2", "value2");
assertThat(tableOptions).containsEntry("opt3", "value4");
assertThat(tableOptions).doesNotContainKey("fs.allow-hadoop-fallback");
assertThat(tableOptions).doesNotContainKey("lock.enabled");
}

Expand Down

0 comments on commit 763f469

Please sign in to comment.