address comments

apache · Sep 26, 2024 · bbdbb2f · bbdbb2f
1 parent e62988e
commit bbdbb2f
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/table/AbstractFileStoreTable.java b/paimon-core/src/main/java/org/apache/paimon/table/AbstractFileStoreTable.java
@@ -166,6 +166,7 @@ public Identifier identifier() {
 
  @Override
  public Optional<Statistics> statistics() {
+ // todo: support time travel
  Snapshot latestSnapshot = snapshotManager().latestSnapshot();
  if (latestSnapshot != null) {
  return store().newStatsFileHandler().readStats(latestSnapshot);
@@ -174,17 +175,16 @@ public Optional<Statistics> statistics() {
  }
 
  @Override
- public Optional<Statistics> statistics(Long snapshotId) {
- if (!snapshotManager().snapshotExists(snapshotId)) {
- throw new SnapshotNotExistException(
- String.format("snapshot id: %s is not existed", snapshotId));
- }
-
+ public Optional<Statistics> statistics(long snapshotId) {
  Long latestSnapshotId = snapshotManager().latestSnapshotId();
  if (latestSnapshotId == null) {
  return Optional.empty();
  }
 
+ if (!snapshotManager().snapshotExists(snapshotId)) {
+ return store().newStatsFileHandler().readStats(snapshotManager().latestSnapshot());
+ }
+
  while (latestSnapshotId > 0) {
  Snapshot latestSnapshot = snapshotManager().snapshot(latestSnapshotId);
  // reduce unnessary loop

diff --git a/paimon-core/src/main/java/org/apache/paimon/table/DelegatedFileStoreTable.java b/paimon-core/src/main/java/org/apache/paimon/table/DelegatedFileStoreTable.java
@@ -129,7 +129,7 @@ public Optional<Statistics> statistics() {
  }
 
  @Override
- public Optional<Statistics> statistics(Long snapshotId) {
+ public Optional<Statistics> statistics(long snapshotId) {
  return wrapped.statistics(snapshotId);
  }
 

diff --git a/paimon-core/src/main/java/org/apache/paimon/table/FormatTable.java b/paimon-core/src/main/java/org/apache/paimon/table/FormatTable.java
@@ -217,7 +217,7 @@ default Optional<Statistics> statistics() {
  }
 
  @Override
- default Optional<Statistics> statistics(Long snapshotId) {
+ default Optional<Statistics> statistics(long snapshotId) {
  return Optional.empty();
  }
 

diff --git a/paimon-core/src/main/java/org/apache/paimon/table/ReadonlyTable.java b/paimon-core/src/main/java/org/apache/paimon/table/ReadonlyTable.java
@@ -62,7 +62,7 @@ default Optional<Statistics> statistics() {
  }
 
  @Override
- default Optional<Statistics> statistics(Long snapshotId) {
+ default Optional<Statistics> statistics(long snapshotId) {
  return Optional.empty();
  }
 

diff --git a/paimon-core/src/main/java/org/apache/paimon/table/Table.java b/paimon-core/src/main/java/org/apache/paimon/table/Table.java
@@ -75,7 +75,7 @@ default String fullName() {
  Optional<Statistics> statistics();
 
  @Experimental
- Optional<Statistics> statistics(Long snapshotId);
+ Optional<Statistics> statistics(long snapshotId);
 
  // ================= Table Operations ====================