[core] Delete redundant if statement when produce changelog by lookup for first row. #4270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ut is fail, but not caused by my modify. |
Aitozi
reviewed
Sep 27, 2024
| return reusedResult.addChangelog(result); | ||
| } | ||
|
|
||
| // mergeFunction.containsHighLevel is false, so new record, output changelog |
There was a problem hiding this comment.
what about
// new record, output changelog
return reusedResult.setResult(result).addChangelog(result);
There was a problem hiding this comment.
done
good, very thanks.
wwj6591812
force-pushed
the
delete_redundant_in_FirstRowMergeFunctionWrapper_0927
branch
from
7deae95
to
5c16018
Compare
wwj6591812
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When I study the logic of produce changelog, I find a redundant if statement affects my understanding of the code logic.
In order not to affect more people, so now delete it.
Linked issue: close #xxx
Tests
Existing tests should cover this change.
API and Format
Documentation