[core] Remove properties field in FileStoreCommit.commit#5731
Merged
JingsongLi merged 1 commit intoapache:masterfrom Jun 11, 2025
Merged
[core] Remove properties field in FileStoreCommit.commit#5731JingsongLi merged 1 commit intoapache:masterfrom
JingsongLi merged 1 commit intoapache:masterfrom
Conversation
luoyuxia
approved these changes
Jun 11, 2025
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@JingsongLi Thanks for the pr. The properties does confuse me while implementing #5703. LGTM!
yuzelin
pushed a commit
to yuzelin/paimon
that referenced
this pull request
Jun 13, 2025
(cherry picked from commit 4874e68)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In #5703 , there is properties in
ManifestCommittable.We don't need properties field in FileStoreCommit.commit.
Tests
API and Format
Documentation