PARQUET-12: Add format support for additional converted types.#3
Closed
jacques-n wants to merge 2 commits intoapache:masterfrom
Closed
PARQUET-12: Add format support for additional converted types.#3jacques-n wants to merge 2 commits intoapache:masterfrom
jacques-n wants to merge 2 commits intoapache:masterfrom
Conversation
src/thrift/parquet.thrift
Outdated
There was a problem hiding this comment.
Is time always relative to midnight UTC, or is it based on the current timezone?
Contributor
Author
There was a problem hiding this comment.
Time is disconnected from any timezone given that it is without a date context.
Member
Member
Contributor
|
Looks good to me. I'll merge tomorrow. |
Contributor
|
+1. Thanks Jacques! |
dvryaboy
pushed a commit
to dvryaboy/incubator-parquet-format
that referenced
this pull request
Aug 24, 2014
Original from the old repo: Parquet/parquet-mr#410 JIRA: https://issues.apache.org/jira/browse/PARQUET-2 These changes allow primitive types to be requested as different types than what is stored in the file format using a flag to turn off strict type checking (default is on). Types are cast to the requested type where possible and will suffer precision loss for casting where necessary (e.g. requesting a double as an int). No performance penalty is imposed for using the type defined in the file type. A flag exists to A 6x6 test case is provided to test conversion between the primitive types. Author: Daniel Weeks <dweeks@netflix.com> Closes apache#3 from dcw-netflix/type-persuasion and squashes the following commits: 97f4e9a [Daniel Weeks] Added documentation as suggested by code review 1c3c0c7 [Daniel Weeks] Fixed test with strict checking off f3cb495 [Daniel Weeks] Added type persuasion for primitive types with a flag to control strict type checking for conflicting schemas, which is strict by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.