PARQUET-11: Reduce memory pressure when reading footers #7
Closed
julienledem wants to merge 3 commits intoapache:masterfrom
Closed
PARQUET-11: Reduce memory pressure when reading footers #7julienledem wants to merge 3 commits intoapache:masterfrom
julienledem wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
+1 LGTM |
lekv
pushed a commit
to lekv/parquet-format
that referenced
this pull request
Jul 31, 2017
I find out some very minor issue when I tried to compile the reader on my environment due to some namespace clashing. As example shared_ptr and unordered_map are also in C++11 std namespace. Some compile don't like it. Also I find that with my test files that I'm reading there was a dereference to a null pointer, if the field is required definition_level_decoder_ is null. Author: Fabrizio Fabbri <ffabbri4@bloomberg.net> Closes apache#7 from ffabbri4/candidate and squashes the following commits: 3f8a445 [Fabrizio Fabbri] Fix null pointer when the repetition level is required. 2948584 [Fabrizio Fabbri] Explicit include boost shared pointer header. specify boost::unordered_map as on C++11 is ambiguous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on https://github.com/apache/incubator-parquet-format/pull/2