Check ParquetWriter constructor compatibility with 1.5.0

[asfimport]

ParquetWriter constructors may have an incompatible change

Reporter: Ryan Blue / @rdblue
Assignee: Ryan Blue / @rdblue

Related issues:

• Release parquet-mr 1.6.0 (blocks)

_{Note: This issue was originally created as PARQUET-237. Please see the migration documentation for further details.}

[asfimport]

Ryan Blue / @rdblue:
The commits since 1.5.0 all look fine, but the binary changes appear to have a problem (sorry it is hard to read):

Class parquet.hadoop.ParquetWriter
 Added Method <init>, sig (Lorg/apache/hadoop/fs/Path;Lparquet/hadoop/ParquetFileWriter$Mode;Lparquet/hadoop/api/WriteSupport<TT;>;Lparquet/hadoop/metadata/CompressionCodecName;IIIZZLparquet/column/ParquetProperties$WriterVersion;Lorg/apache/hadoop/conf/Configuration;)V, desc (Lorg/apache/hadoop/fs/Path;Lparquet/hadoop/ParquetFileWriter$Mode;Lparquet/hadoop/api/WriteSupport;Lparquet/hadoop/metadata/CompressionCodecName;IIIZZLparquet/column/ParquetProperties$WriterVersion;Lorg/apache/hadoop/conf/Configuration;)V, access public
 Removed Method <init>, sig (Lorg/apache/hadoop/fs/Path;Lparquet/hadoop/api/WriteSupport<TT;>;Lparquet/hadoop/metadata/CompressionCodecName;IIIZZLorg/apache/hadoop/conf/Configuration;)V, desc (Lorg/apache/hadoop/fs/Path;Lparquet/hadoop/api/WriteSupport;Lparquet/hadoop/metadata/CompressionCodecName;IIIZZLorg/apache/hadoop/conf/Configuration;)V, access public
 Added Method <init>, sig (Lorg/apache/hadoop/fs/Path;Lorg/apache/hadoop/conf/Configuration;Lparquet/hadoop/api/WriteSupport<TT;>;)V, desc (Lorg/apache/hadoop/fs/Path;Lorg/apache/hadoop/conf/Configuration;Lparquet/hadoop/api/WriteSupport;)V, access public

I have no idea why that's there, so it would be great to have someone else take a look.

[asfimport]

Julien Le Dem / @julienledem:
"" is the name of the constructor in the bytecode.
Added ones should not be a problem, so it looks like it's complaining about removing:
ParquetWriter(Path, WriteSupport, CompressionCodecName, Configuration)
it should be easy to make one that calls this one with defaults for the other parameters:
https://github.com/apache/incubator-parquet-mr/blob/bfb314505469afcd5ea7b5bd15121acd50425318/parquet-hadoop/src/main/java/parquet/hadoop/ParquetWriter.java#L195

[asfimport]

Ryan Blue / @rdblue:
I'm not sure why semver is saying this was removed, but the semver plugin doesn't fail when I check this against 1.5.0 (with Binary and parquet.metadata added to the exclusion list) so I'm going to resolve this.