-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Closed
Description
+flush()+ was added in +RecordConsumer+ and +MessageColumnIO+ to help implementing nulls caching.
However, other +RecordConsumer+ implementations should also implements +flush()+ properly. For instance, +RecordConsumerLoggingWrapper+ and +ValidatingRecordConsumer+ should call +delegate.flush()+ in their +flush()+ methods, otherwise data might be mistakenly truncated.
This ticket:
- makes +flush()+ abstract in +RecordConsumer+
- implements +flush()+ properly for all +RecordConsumer+ subclasses, specifically:
- +RecordConsumerLoggingWrapper+
- +ValidatingRecordConsumer+
- +ConverterConsumer+
- +ExpectationValidatingRecordConsumer+
Reporter: Liwei Lin(Inactive) / @lw-lin
Assignee: Liwei Lin(Inactive) / @lw-lin
Related issues:
PRs and other links:
Note: This issue was originally created as PARQUET-528. Please see the migration documentation for further details.