Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2465: Fall back to HadoopConfig (#1339) #1342

Merged
merged 1 commit into from
May 3, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented May 3, 2024

Backporting the fallback logic

We see that this causes the 1.14 to be incompatible with the previous releases. The config will be created and right after that the getWriteSupport(conf) is called.

But since this method is freshly introduced:

    protected WriteSupport<T> getWriteSupport(ParquetConfiguration conf) {
      throw new UnsupportedOperationException(
          "Override ParquetWriter$Builder#getWriteSupport(ParquetConfiguration)");
    }

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Add fallback logic

We see that this causes the 1.14 to be incompatible
with the previous releases. The config will be created
and right after that the `getWriteSupport(conf)` is called.

But since this method is freshly introduced:

```java
    protected WriteSupport<T> getWriteSupport(ParquetConfiguration conf) {
      throw new UnsupportedOperationException(
          "Override ParquetWriter$Builder#getWriteSupport(ParquetConfiguration)");
    }
```
@wgtmac
Copy link
Member

wgtmac commented May 3, 2024

Thanks for backporting!

BTW, I'm still on vacation until May 6th. I can restart preparation for RC1 after that if there is no hurry.

@Fokko Fokko merged commit bb8c72d into apache:parquet-1.14.x May 3, 2024
9 checks passed
@Fokko Fokko deleted the fd-cherry-pick branch May 3, 2024 10:58
@Fokko
Copy link
Contributor Author

Fokko commented May 3, 2024

@wgtmac It would be nice to get the RC out because of the Spark 4.0 release. I can also send out the mail for RC1 and then you can wrap it up when you're back from vacation

@wgtmac
Copy link
Member

wgtmac commented May 3, 2024

That sounds good. Thanks @Fokko!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants